chore: Add bios-update step and add cluster metadata to the script environment#1752
Merged
Conversation
stevekeay
force-pushed
the
enrol-env-cluster-metadata
branch
from
987535c to
c2d2d1b
Compare
We wanted to do this later in the process, at least after the server is out of "enrol" state so that validation can complete and clean up the BMC for us. However we should do this prior to inspection because: 1) inspection will reboot the box and thereby apply our changes 2) inspection needs to PXE, therefore it won't work until after bios-settings has happened.
stevekeay
force-pushed
the
enrol-env-cluster-metadata
branch
from
c2d2d1b to
f069452
Compare
skrobul
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to run the bios-settings script at the appropriate point in the enrol workflow.
Enrol also needs some metadata to configure the BMC with DNS servers, etc.
We're also supplying it to the bios-settings script for consistency.