chore: split crd installation#1756
Merged
Merged
Conversation
The recommended way to load CRDs with ArgoCD is to do it in another Application and use an earlier sync wave. We'll standardize CRDs at sync wave -2 across the board.
Originally was going to move cert-manager to split up the CRD installation but they do not split out the CRDs so we are unable to do so. However since this chart is needed by a number of other charts, reuse the sync wave to -1 so that is appears earlier in the cluster.
The recommended way to load CRDs with ArgoCD is to do it in another Application and use an earlier sync wave.
skrobul
approved these changes
Mar 5, 2026
Collaborator
skrobul
left a comment
skrobul
left a comment
There was a problem hiding this comment.
Nice!
In regards to docs - it would be nice to have a reference list stating what happens in each sync wave (I know we have that in comments spread across the repo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow the best practices by splitting out the installation of the CRDs where possible and set them to sync wave -2 so they get installed early. cert-manager didn't actually allow for this but since its needed by so many things, move it's sync wave to -1