Skip to content

feat: PUC-1546: Add default password option to enrollment process. #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevekeay merged 2 commits into from
Mar 10, 2026
Merged

feat: PUC-1546: Add default password option to enrollment process. #1788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
988fe2a
PUC-1546: Add default password option to enrollment process.
RSabounds Mar 10, 2026
dc38083
use set to avoid duplicate password attempts.
RSabounds Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/understack-workflows/understack_workflows/bmc_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def set_bmc_password(
"Trying old / factory default credentials."
)

for test_password in filter(None, [old_password, *FACTORY_PASSWORDS]):
for test_password in set(filter(None, [old_password, *FACTORY_PASSWORDS])):
try:
token, session = bmc.get_session(test_password)
except RedfishRequestError as e:
Expand Down
4 changes: 4 additions & 0 deletions workflows/argo-events/workflowtemplates/enroll-server.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ spec:
value: "false"
- name: raid_configure
value: "true"
- name: old_password
value: calvin
Comment thread
RSabounds marked this conversation as resolved.
templates:
- name: main
steps:
Expand Down Expand Up @@ -100,6 +102,8 @@ spec:
args:
- --bmc-ip-address
- "{{workflow.parameters.ip_address}}"
- --old-bmc-password
- "{{workflow.parameters.old_password}}"
volumeMounts:
- mountPath: /etc/openstack
name: baremetal-manage
Expand Down
Loading