feat: preserve pods from post-deploy jobs#1865
Merged
Merged
Conversation
The intent of #1792 was to make it easier to troubleshoot issues that occur but the update didn't touch all the post deploy jobs as it should have. Additionally it still re-runs the failed operations in the same pod which make it less clear for troubleshooting and won't fix cases where the secrets that loaded were out of date. Lastly we should still clean things up in the end to not leave resources consumed so after one hour clean up the pods.
skrobul
approved these changes
Mar 24, 2026
haseebsyed12
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of #1792 was to make it easier to troubleshoot issues that
occur but the update didn't touch all the post deploy jobs as it should
have. Additionally it still re-runs the failed operations in the same
pod which make it less clear for troubleshooting and won't fix cases
where the secrets that loaded were out of date. Lastly we should still
clean things up in the end to not leave resources consumed so after one
hour clean up the pods.