fix(inspect-server): Removes problematic inspect step#1872
Merged
Conversation
cardoe
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem/bug: The step getting removed assumes the ironic provision_state equals the openstack cli command to use such as
openstack baremetal node $command. As an example, for the ironic provision_statemanageableit would try to runopenstack baremetal node manageablewhich is incorrect as it should beopenstack baremetal node manage. I had AI review the ironic and openstackclient repos to find if there were any matches and there's only 1 scenario they match: rescue, however we don't use that in this flow, and I believe you can't inspect a server in rescue either.