fix(neutron): undersync mechanism operate only on baremetal ports PUC-1713#2058
Merged
Conversation
nidzrai
force-pushed
the
undersync_mech_baremetal_only
branch
2 times, most recently
from
667b49c to
c9aa243
Compare
nidzrai
changed the title
stevekeay
approved these changes
Jun 2, 2026
Contributor
stevekeay
left a comment
stevekeay
left a comment
There was a problem hiding this comment.
LGTM although I would vastly prefer if the commit message were amended to add a paragraph describing why this change was made.
skrobul
reviewed
Jun 2, 2026
Collaborator
skrobul
left a comment
skrobul
left a comment
There was a problem hiding this comment.
can you provide bit more context for this PR ?
What's the rationale behind excluding 'normal' ports? I may be wrong here, but I think Undersync still requires visibility of those port types which are commonly applied on trunk subports and router interfaces.
stevekeay
requested changes
Jun 2, 2026
Contributor
stevekeay
left a comment
stevekeay
left a comment
There was a problem hiding this comment.
There appears to be a merge commit in this PR?
nidzrai
force-pushed
the
undersync_mech_baremetal_only
branch
from
1dd6303 to
2d67d15
Compare
nidzrai
force-pushed
the
undersync_mech_baremetal_only
branch
from
2d67d15 to
61e5335
Compare
stevekeay
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.