fix: do not delete whitespace between dnsmasq options #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoe
force-pushed
the
dnsmasq-option-whitespace
branch
from
34308ff to
5f040db
Compare
This minus sign causes us to delete all whitespace prior which creates all the for loop items on the same line creating an invalid config. They need to be on their own line.
cardoe
force-pushed
the
dnsmasq-option-whitespace
branch
from
5f040db to
4a7f392
Compare
nicholaskuechler
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minus sign causes us to delete all whitespace prior which creates all the for loop items on the same line creating an invalid config. They need to be on their own line.