Skip to content

chore: renovate rule to watch OpenStack Helm #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2024
Merged

chore: renovate rule to watch OpenStack Helm #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a29414f
docs: fix docs generation for workflows
cardoe Oct 25, 2024
4493c78
ci: validate renovate configs in pre-commit
cardoe Oct 25, 2024
9462a65
ci: add renovate rule to track OpenStack Helm releases
cardoe Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,24 @@
":prNotPending",
":rebaseStalePrs",
":automergeDigest"
],
"customDatasources": {
"openstackhelm": {
"defaultRegistryUrlTemplate": "https://tarballs.opendev.org/openstack/openstack-helm/",
"format": "html",
"transformTemplates": [
"{\"releases\": $map($filter($.releases, function($v) {$match($v.version, /^{{packageName}}-/)}), function($v) { {\"version\": $match($v.version, /^{{packageName}}-([0-9.]+).tar.gz$/).groups[0]} } ) }"
Copy link
Collaborator

@skrobul skrobul Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"{\"releases\": $map($filter($.releases, function($v) {$match($v.version, /^{{packageName}}-/)}), function($v) { {\"version\": $match($v.version, /^{{packageName}}-([0-9.]+).tar.gz$/).groups[0]} } ) }"
"{\"releases\": $map($filter($.releases, function($v) {$match($v.version, /^{{packageName}}-/)}), function($v) { {\"version\": $match($v.version, /^{{packageName}}-([0-9.]+)\\.tar\\.gz$/).groups[0]} } ) }"

We may want to escape the literal dots here, but I bet the original version still works so nbd

Copy link
Contributor Author

@cardoe cardoe Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I dunno. I used the recommended website to craft the rule and then escaped it until the checker was happy. Not sure if it'll do the right thing yet.

Copy link
Contributor Author

@cardoe cardoe Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should we do with the PR?

]
}
},
"customManagers": [
{
"customType": "regex",
"fileMatch": ["\\.yaml$"],
"datasourceTemplate": "custom.openstackhelm",
"matchStrings": [
"#\\s*renovate:\\s*(datasource=(?<datasource>.*?)\\s*)?depName=(?<depName>.*?)\\s*chartVersion:\\s*(?<currentValue>.+?)\\s"
]
}
]
}
4 changes: 4 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,7 @@ repos:
name: "poetry-lock (understack-workflows)"
files: '^python/understack-workflows/'
args: ["-C", "python/understack-workflows", "--no-update"]
- repo: https://github.com/renovatebot/pre-commit-hooks
rev: 38.114.0
hooks:
- id: renovate-config-validator
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ $(ACTIVATE): requirements-docs.txt
@$(PIP) install -U -r requirements-docs.txt
@touch $(ACTIVATE)

docs/workflows: $(ACTIVATE)
docs/workflows/argo-events.md: $(ACTIVATE)
@mkdir -p docs/workflows
@$(PYTHON) scripts/argo-workflows-to-mkdocs.py workflows docs/workflows

.PHONY: docs
docs: $(ACTIVATE) docs/workflows ## Builds the documentation
docs: $(ACTIVATE) docs/workflows/argo-events.md ## Builds the documentation
$(MKDOCS) build --strict

.PHONY: docs-local
docs-local: $(ACTIVATE) docs/workflows ## Build and locally host the documentation
docs-local: $(ACTIVATE) docs/workflows/argo-events.md ## Build and locally host the documentation
$(MKDOCS) serve --strict
7 changes: 7 additions & 0 deletions apps/appsets/openstack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,25 @@ spec:
- list:
elements:
- component: keystone
# renovate: datasource=custom.openstackhelm depName=keystone
chartVersion: 0.3.15
- component: ironic
# renovate: datasource=custom.openstackhelm depName=ironic
chartVersion: 0.2.18
- component: placement
# renovate: datasource=custom.openstackhelm depName=placement
chartVersion: 0.3.16
- component: neutron
# renovate: datasource=custom.openstackhelm depName=neutron
chartVersion: 0.3.47
- component: glance
# renovate: datasource=custom.openstackhelm depName=glance
chartVersion: 0.5.0
- component: nova
# renovate: datasource=custom.openstackhelm depName=nova
chartVersion: 0.3.44
- component: horizon
# renovate: datasource=custom.openstackhelm depName=horizon
chartVersion: 0.3.28
template:
metadata:
Expand Down
1 change: 0 additions & 1 deletion workflows/argo-events/docs/README.md
View file
Open in desktop

This file was deleted.