"Find" feature is off by one

[sinistersnare]

Hi, in DrRacket, when I use ctrl-f to find something, the results found section is off by one.

There are indeed 7 matches, but it only cycles 0-1-2-3-4-5-6-0-....

AKA If you go to Selection 6 and go to the next, it wraps back to 0.

So a possible solution would be instead to make the 'denominator' 0-indexed too, or make the 'numerator' 1-indexed.

[rfindler]

I think that the subject line here is perhaps not quite right. Say you are searching for b have this content in your editor:

a b a b a

If you move the insertion point through the buffer and watch the numbers change, you'll se that all of the possibilities (0/2 through 2/2) are accounted for an make some sense.

[sinistersnare]

If I type in

a b a b a

And Ctrl-F a

1. When I first type in a it says I have 3/3 matches.
2. Hitting enter will bring me to match 0 / 3
3. Hitting enter will bring me to match 1 / 3
4. Hitting enter will bring me to match 2 / 3
5. Hitting enter will bring me to match 0 / 3

I feel like 0 should not be an option here, it should cycle 1->2->3->1->... not 0->1->2->0->..., or we should change the amount of matches to '2', even though that is an off-by-one for people who use ctrl-f to see how many instances of a name there is.

[rfindler]

This appears to have been fixed at some point in the past but there were some lingering issues nearby in the code that the commit mentioned above fixes. With those fixes, the test cases now correctly match the behavior I see in DrRacket so I'll close this now.