Fixing the comment-at-end-of-file bug (PR#11982) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, with some differences -- the ()s are not needed in the regexp (and the test is moved to a slightly better place). |
mflatt
added a commit
to mflatt/racket
that referenced
this pull request
Nov 24, 2017
mflatt
pushed a commit
to mflatt/racket
that referenced
this pull request
Jul 8, 2022
and tidy up the docs a little too closes racket#17
LiberalArtist
added a commit
to LiberalArtist/racket
that referenced
this pull request
Jun 30, 2023
This is the 1st commit message:
core dumped
```
$ racket -e- "(require (submod \"indent.rkt\" cli))" --generate-from-nat 0
free(): invalid pointer
Aborted (core dumped)
```
core.racket.1000.4b1a76207d9343cca36f822f45045648.1276489.1687697303000000.zst
seems to be a Guix issue, having done `guix shell node` just before:
```
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ raco cross --workspace 20230612-5c15ebc0da/ racket -e- "(require (submod \"indent.rkt\" cli))" --generate-from-nat 0
>> Cross configuration
Target: x86_64-linux [native]
Host: x86_64-linux
Version: current
VM: cs
Workspace: /home/philip/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json/20230612-5c15ebc0da/
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ racket --version
free(): invalid pointer
Aborted (core dumped)
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ guix describe --format=chanels
guix describe: error: chanels: unsupported output format
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ guix describe --format=channels
(list (channel
(name 'guix)
(url "https://git.savannah.gnu.org/git/guix.git")
(branch "master")
(commit
"6bc3e3f9baa52beb318dde77d1773ae83aa8683e")
(introduction
(make-channel-introduction
"9edb3f66fd807b096b48283debdcddccfea34bad"
(openpgp-fingerprint
"BBB0 2DDF 2CEA F6A8 0D1D E643 A2A0 6DF2 A33A 54FA")))))
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ guix build --source racket
gnu/packages/racket.scm:646:2: warning: package 'racket' has no source
guix build: warning: no arguments specified, nothing to do
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ guix build --source racket-minimal
gnu/packages/racket.scm:540:2: warning: package 'racket-minimal' has no source
guix build: warning: no arguments specified, nothing to do
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ guix build --source zuo
10.3 MB will be downloaded:
/gnu/store/hf00x4k3yl8wfz9f7vcrk3am4bsf40ib-racket-8.8-checkout
substituting /gnu/store/hf00x4k3yl8wfz9f7vcrk3am4bsf40ib-racket-8.8-checkout...
downloading from https://bordeaux-us-east-mirror.cbaines.net/nar/lzip/hf00x4k3yl8wfz9f7vcrk3am4bsf40ib-racket-8.8-checkout ...
racket-8.8-checkout 9.9MiB 2.4MiB/s 00:04 ▕██████████████████▏ 100.0%
/gnu/store/hf00x4k3yl8wfz9f7vcrk3am4bsf40ib-racket-8.8-checkout
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ guix build --source zuo
10.3 MB will be downloaded:
/gnu/store/hf00x4k3yl8wfz9f7vcrk3am4bsf40ib-racket-8.8-checkout
substituting /gnu/store/hf00x4k3yl8wfz9f7vcrk3am4bsf40ib-racket-8.8-checkout...
downloading from https://bordeaux-us-east-mirror.cbaines.net/nar/lzip/hf00x4k3yl8wfz9f7vcrk3am4bsf40ib-racket-8.8-checkout ...
racket-8.8-checkout 9.9MiB 2.4MiB/s 00:04 ▕██████████████████▏ 100.0%
/gnu/store/hf00x4k3yl8wfz9f7vcrk3am4bsf40ib-racket-8.8-checkout
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ guix build racket
/gnu/store/yfhyx94p1cqv7lip1mambz4pqsxxfblh-racket-8.8
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ which racket
/home/philip/.guix-home/profile/bin/racket
philip@bastet:~/code/21.10-bastet/tmp/racket/pkgs/racket-test/tests/json$ realpath $(command -v racket)
/gnu/store/c9l5fwhfmdspnyn5ch2g522ssxkh530a-racket-8.8/bin/racket
```
This is the commit message #2:
cli
This is the commit message racket#3:
export NODE=$(guix build node)/bin/node
This is the commit message racket#4:
wip define-main
This is the commit message racket#5:
wip
This is the commit message racket#6:
reorder submodules
This is the commit message racket#7:
wip (reverse course)
This is the commit message racket#8:
getting closer
This is the commit message racket#9:
let's give up on returning values
This is the commit message racket#10:
successfully `indent-test-data-cli --add-from-nat 0`
This is the commit message racket#11:
older staged changes
This is the commit message racket#12:
memory issues with constrained enums
This is the commit message racket#13:
wip enum explorations
This is the commit message racket#14:
wip: constrained enums not working out; try more explicit random generation
This is the commit message racket#15:
wip still hitting memory issues
This is the commit message racket#16:
wip
This is the commit message racket#17:
wip
This is the commit message racket#18:
sort of works! may need hex digits
> (add-random 1)
'(2848930389620247766709815174939771952410606836852644054419616072062066823091825094120243303024853753235996297471587209972238169731486575190285623445337837072665884)
> (number->string 2848930389620247766709815174939771952410606836852644054419616072062066823091825094120243303024853753235996297471587209972238169731486575190285623445337837072665884 16)
"caa3b77a70ffc91d39bda5a1a2938eb30ba3ef5aa5eeeb55979f0e98af9583fe1b9cd42d2d6263288dc017fe68918344c27ad454e59d34e22737cee384fbae28a3dcd1c"
> (string-length "caa3b77a70ffc91d39bda5a1a2938eb30ba3ef5aa5eeeb55979f0e98af9583fe1b9cd42d2d6263288dc017fe68918344c27ad454e59d34e22737cee384fbae28a3dcd1c")
135
> (require net/base64)
> (integer-length 2848930389620247766709815174939771952410606836852644054419616072062066823091825094120243303024853753235996297471587209972238169731486575190285623445337837072665884)
540
This is the commit message racket#19:
gzip still too big
This is the commit message racket#20:
wip
This is the commit message racket#21:
wip pruning enum
This is the commit message racket#22:
almost ready
This is the commit message racket#23:
fix error reporting; fix errors; add actual tests
This is the commit message racket#24:
works!
$ indent-test-data-cli -r 12
Added randomly-chosen data in these directories:
3b8c89c/
6ef2ee0/
a8206c9/
6eddee1/
b9f381f/
8f7d34e/
ba47ab2/
3414e05/
0b80275/
aa49306/
872bb9a/
eecfb21/
$ indent-test-data-cli -p
This is the commit message racket#25:
write the tests
This is the commit message racket#26:
cleanup
This is the commit message racket#27:
add (failing-directories)
LiberalArtist
added a commit
to LiberalArtist/racket
that referenced
this pull request
Jul 11, 2025
This is a combination of 20 commits. This is the 1st commit message: wip rktio icu This is the commit message #2: typo fix This is the commit message racket#3: hack for testing This is the commit message racket#4: fixup This is the commit message racket#5: fixup more This is the commit message racket#6: RKTIO_NO_ICU -> RKTIO_HAVE_ICU This is the commit message racket#7: fixup set_racket_error This is the commit message racket#8: autoconf This is the commit message racket#9: fixup iconv.m4 This is the commit message racket#10: attempt at winfig.bat for ICU This is the commit message racket#11: debug winfig.bat This is the commit message racket#12: another try at winfig.bat This is the commit message racket#13: tollerate "''" from top-level Makefile in build.bat This is the commit message racket#14: maybe it is "" This is the commit message racket#15: remove some obsolete files This is the commit message racket#16: winfig.bat: try ignoring all unknown args This is the commit message racket#17: debug This is the commit message racket#18: winfig.bat: fewer quotation marks This is the commit message racket#19: remove even more quotation marks This is the commit message racket#20: [wip] drop RKTIO_ICU_DLL; revamp initialization
LiberalArtist
added a commit
to LiberalArtist/racket
that referenced
this pull request
Oct 4, 2025
(Also, rebased and resolved parallel-thread–related conflicts. This is a combination of 5 commits. This is the 1st commit message: [wip] rktio icu - progress before 2023-12-15 This is a combination of 20 commits. This is the 1st commit message: wip rktio icu This is the commit message #2: typo fix This is the commit message racket#3: hack for testing This is the commit message racket#4: fixup This is the commit message racket#5: fixup more This is the commit message racket#6: RKTIO_NO_ICU -> RKTIO_HAVE_ICU This is the commit message racket#7: fixup set_racket_error This is the commit message racket#8: autoconf This is the commit message racket#9: fixup iconv.m4 This is the commit message racket#10: attempt at winfig.bat for ICU This is the commit message racket#11: debug winfig.bat This is the commit message racket#12: another try at winfig.bat This is the commit message racket#13: tollerate "''" from top-level Makefile in build.bat This is the commit message racket#14: maybe it is "" This is the commit message racket#15: remove some obsolete files This is the commit message racket#16: winfig.bat: try ignoring all unknown args This is the commit message racket#17: debug This is the commit message racket#18: winfig.bat: fewer quotation marks This is the commit message racket#19: remove even more quotation marks This is the commit message racket#20: [wip] drop RKTIO_ICU_DLL; revamp initialization This is the commit message #2: [wip] fixup & uloc_getDefault() This is the commit message racket#3: fixup This is the commit message racket#4: fixup This is the commit message racket#5: set callbacks to stop on illegal/unmapped/invalid sequences Apparently, ICU's default behavior is to emit a substitution character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test case and adjusted the reader so it handles EOF when the last line is @; commented.