Analyze pull requests with Resyntax #336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Are the CI failures for the PR something to be fixed, first? I'm not really clear on how this is supposed to work. |
Contributor
Author
|
Yeah, this shouldn't be merged until it's passing. I'll mark it as a draft PR for now to make that clearer, and I'll investigate the failures when I get some time for it. |
Contributor
Author
|
Closing this in favor of #350. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a similar pull request to racket/typed-racket#1250. @mflatt suggested the Scribble repository as another good project to try Resyntax on, since it's old, large, and frequently receives pull requests. See the typed racket pull request for details about what this change does. TL;DR: it runs Resyntax over pull requests and leaves github reviews with suggested improvements.