Analyze pull requests with Resyntax #1250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm not sure what went wrong with the CI run, @jackfirth can you take a look? |
Contributor
Author
|
@samth Fixed! |
Member
|
Can you squash the commits here? Also, why does it need xvfb? |
Contributor
|
Probably because it uses @jackfirth you might be able to remove the |
Contributor
Author
|
@sorawee There isn't currently an implementation of |
Analyze pull requests with Resyntax @samth expressed interest in setting up [Resyntax](https://docs.racket-lang.org/resyntax/) in the Typed Racket repository. This CL adds a github workflow which runs Resyntax on any changed files in a pull request. Resyntax will suggest changes in the form of a github review, [like this](jackfirth/racket-package-resyntax-action#9 (review)). To apply the changes, the pull request author simply need click the "Commit suggestion" button that shows up in each comment. Suggestions can also be ignored freely; the review does not block merges. The tool and the github integration are both still in the early phases so there are probably several bugs to work out here. If a suggestion looks wonky, @-mention me and I'll take a look at it.
Contributor
Author
|
@samth Squashed |
This was referenced Jun 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samth expressed interest in setting up Resyntax on the Typed Racket repository. This pull request adds a github workflow that runs Resyntax on any changed files in a pull request. Resyntax will suggest changes via a github review, like this. To apply the changes, the pull request author can click the "Commit suggestion" button that shows up in each comment. Suggestions can be ignored freely; the review does not block merges. Here's an example of what a Resyntax suggestion looks like for someone with commit access:
The Resyntax tool and especially the github integration are still in the early phases of development so there are probably several bugs to work out here. If a suggestion looks wonky, @-mention me and I'll take a look at it.