Skip to content

[DO NOT MERGE]: Add some code for Resyntax to analyze #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE]: Add some code for Resyntax to analyze #1277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions typed-racket-lib/typed-racket/private/refactorable-code-example.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#lang racket/base


(define (distance x1 y1 x2 y2)
(let ([dx (- x1 x2)]
[dy (- y1 y2)])
(sqrt (+ (* dx dx) (* dy dy)))))
Comment on lines +4 to +7
Copy link

@github-actions github-actions bot Sep 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.

Suggested change
(define (distance x1 y1 x2 y2)
(let ([dx (- x1 x2)]
[dy (- y1 y2)])
(sqrt (+ (* dx dx) (* dy dy)))))
(define (distance x1 y1 x2 y2)
(define dx (- x1 x2))
(define dy (- y1 y2))
(sqrt (+ (* dx dx) (* dy dy))))
Debugging details
Textual replacement 
(line-replacement
  #:new-lines
    '#("(define (distance x1 y1 x2 y2)"
       "  (define dx (- x1 x2))"
       "  (define dy (- y1 y2))"
       "  (sqrt (+ (* dx dx) (* dy dy))))")
  #:original-lines
    '#("(define (distance x1 y1 x2 y2)"
       "  (let ([dx (- x1 x2)]"
       "        [dy (- y1 y2)])"
       "    (sqrt (+ (* dx dx) (* dy dy)))))")
  #:start-line 4)
Syntactic replacement 
(syntax-replacement
  #:new-syntax
    #<syntax:/home/runner/.local/share/racket/snapshot/pkgs/resyntax/default-recommendations/let-binding-suggestions.rkt:44:3 (define (distance x1 y1 x2 y2) NEWLINE (define dx (- x1 x2)) NEWLINE (define dy (- y1 y2)) NEWLINE (sqrt (+ (* dx dx) (* dy dy))))>
  #:original-syntax
    #<syntax:typed-racket-lib/typed-racket/private/refactorable-code-example.rkt:4:0 (define (distance x1 y1 x2 y2) (let ((dx (- x1 x2)) (dy (- y1 y2))) (sqrt (+ (* dx dx) (* dy dy)))))>)