Skip to content

Allow fd zero as return value from socket #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmculpepper merged 1 commit into from
Oct 18, 2025
Merged

Allow fd zero as return value from socket #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions unix-socket-lib/racket/unix-socket.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
;; Should be called in atomic mode.
(define (do-make-socket who)
(define socket-fd (socket AF-UNIX SOCK-STREAM 0))
(unless (positive? socket-fd)
(when (negative? socket-fd)
(error who "failed to create socket~a"
(errno-error-lines (saved-errno))))
(set-fd-nonblocking who socket-fd)
Expand Down Expand Up @@ -160,7 +160,7 @@
;; Non-blocking connect may succeed immediately or require waiting to see.
;; - If succeeds immediately, make ports in same atomic block
;; - If wait, must exit atomic mode to sync
;; So we return a procedure to be applied in non-atomic mode that does
;; So we return a procedure to be applied in non-atomic mode that does
;; whatever needs doing.
(call-as-atomic
(lambda ()
Expand Down
Loading