-
Notifications
You must be signed in to change notification settings - Fork 180
[rfr] Add blockstorage v2 APIs #485
Conversation
It looks like you just copy-and-pasted from |
@jrperritt we cannot proxy those request to v1, because there are some minor differences between the data structure. For example, List API calls different URL and return different json as to v1 |
@feiskyer is right, I think. I was just about to open a PR with my own take on this, but thought I'd see if someone else had gotten to it first. Very close timing :) Here's my branch: https://github.com/jtopjian/gophercloud/tree/openstack-blockstorage-v2 I split the commits apart by the different BlockStorage features currently in Gophercloud so you can see the differences. It's interesting that @feiskyer did the same thing as I for the My branch has a few areas that I've noted that were particularly confusing to me. With all this said, unit and acceptance tests pass, so it's not horribly off. |
@jrperritt I did a quick comparison between the
For The I probably just don't understand the approach that you're suggesting well enough. @feiskyer: Are you able to do a diff on v1 and v2 and recommit? That may make reviewing easier. Also, did you copy over the acceptance tests, too? I don't see them in the commit, but maybe I missed them. If you'd like I could open a PR with my branch that has the above two items done. And finally, regarding your notes in #461 about volume attach, IMO, the |
Would individual PRs for |
@jtopjian It's true that in the end it's the same. Of course, splitting them out into separate PRs will be [seemingly] easier to review and individual subservices can be merged more quickly (namely, most users would likely want the |
@jrperritt sounds good. @feiskyer I don't want to step on your feet or steal your commit. Do you want to break this out into separate PRs? I think having diffs from the original v1 code as well as acceptance tests are needed, too. |
@jrperritt @jtopjian #489 Add volumes part of blockstorage v2 API @jrperritt By the way, has |
@feiskyer Travis doesn't run the acceptance tests for 2 reasons:
|
No description provided.