Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Conversation

feiskyer
Copy link
Contributor

Add more APIs for Cinder:

  • attach
  • detach
  • reserve
  • unreserve
  • initialize_connection
  • terminate_connection

@feiskyer
Copy link
Contributor Author

cc @jrperritt @smashwilson

Will someone merge this PR?

@jamiehannaford
Copy link
Contributor

@feiskyer Don't these operations belong in Cinder v2? You've added them to the v1 package.

@feiskyer
Copy link
Contributor Author

@jamiehannaford Those APIs are not list at Cinder v2 and Cinder v1, but they are both working.

@jrperritt
Copy link
Contributor

Where are these actions documented? I see the attach action here but not the rest.

@feiskyer
Copy link
Contributor Author

@jrperritt There actions are defined at here. They are called directly by nova, but unfortunately not documented. These apis are useful for those who don't need nova.

@jrperritt
Copy link
Contributor

Ah, OK. At the least, these operations should be moved the the v2 package, and unit and acceptance tests should be added. Though they may work with v1, I'd prefer to add new functionality to the non-deprecated version.

@feiskyer
Copy link
Contributor Author

@jrperritt Cinder v2 #485 committed

@jrperritt
Copy link
Contributor

Closing in favor of #485 ; I think that PR contains all this and more. @feiskyer let me know if that's not the case.

@jrperritt jrperritt closed this Sep 16, 2015
@feiskyer
Copy link
Contributor Author

@jrperritt #485 contains all this and more, It's OK to close this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants