[Delivers #49344721 Fix Volume - Attachment property to resolve serialization issues#1
Merged
alanquillin merged 1 commit intorackspace:masterfrom May 8, 2013
Conversation
Author
|
@alanquillin Can you please review this for me, should be fairly straight forward. |
|
+1 Looks good |
alanquillin
added a commit
that referenced
this pull request
May 8, 2013
…bjectIssue [Delivers #49344721 Fix Volume - Attachment property to resolve serialization issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This will resolve an issue for the Cloud Block Storage provider when it is attempting to serialize the volume object's "Attachments" property. Currently the "Attachments" property is currently set as a string array and it needs to be a dictionary<string,string> to be able to handle what is being sent from the API correctly.
Testing
Ran full integration tests and all passed.