Workspace-level storage isolation & attachment cleanup#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{workspaceId}/on disk, enabling per-workspace management, cleanup, and data export.attachments/category) are removed. Attachments now exclusively link to Drive files — no more dual storage path."general"purpose fallback in the upload controller is gone. Uploads now require an explicitworkspaceIdand a validpurpose(avatarorwiki), otherwise they're rejected.YYYY/MMdate-based subdirectories inbuildPathare removed. Files are stored directly under their scope directory./storage/avatars/,/storage/uploads/,/uploads/) remain so existing files still resolve. A new/storage/:workspaceId/uploads/*route serves workspace-scoped uploads.New storage structure
Changes
Backend
workspaceIdandpurposefrom form data, use{workspaceId}/uploadsas storage category, removegeneralfallback{workspaceId}/filescategory inuploadFileStreamandcopyFile{workspaceId}/uploadscategory for re-uploaded assets, remove attachment restore logicYYYY/MMdate directories frombuildPath/storage/:workspaceId/uploads/*route viareply.sendFile(), enabledecorateReplyon first registrationuploadAttachmentHandlerand direct-upload storage deleteuploadAttachmentStream, simplify download to use linked Drive file onlyPOST /workspaces/:wid/attachmentsrouteattachments/from ZIP parsingattachments/prefix from ZIP entry extractionFrontend
workspaceIdand optionalspaceIdtoUploadInput, send in form dataworkspaceIdandspaceIdprops, send in upload form dataworkspaceIdtoWikiEditorworkspace.idtoWikiPageViewworkspaceIdin avatar upload call with guardworkspaceIdfrom route params, pass in avatar upload call with guardShared
CreateAttachmentSchema(no longer used)attachmentsfromRestoreSummary