Fixing security and quality issues#21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 8 security and quality audit issues across the backend and frontend, ranging from critical vulnerabilities to low-priority type safety improvements.
Critical
LocalStorageProvider.read/readStream/delete/existsnow resolve paths and reject any that escape the root directory.GET /storage/:workspaceId/uploads/*now requires authentication, verifies workspace membership, and rejects traversal attempts.High
isInstanceAdminboolean on the User model. First registered user is automatically granted instance admin. Includes migration.Medium
sanitizeReturnUrl()that rejects//,\, and null bytes in both raw and decoded form. Applied in login and callback handlers.sendVerificationEmail/sendPasswordResetEmailcalls now useawaitto surface unhandled promise rejections.POST /api/workspacesis now rate-limited to 5 requests per minute per client.Low
as anyin backup services — Introduced typed helpers (toCustomFieldType,toPriority,toJsonValue) and narrowed conditional includes with inline type annotations, eliminating allas anycasts.eslint-disable-linesuppression withuseRef-based tracking so the cleanup effect reads latest values without needing them as dependencies.