Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 94.40% 94.35% -0.06%
==========================================
Files 107 106 -1
Lines 4754 4623 -131
Branches 272 251 -21
==========================================
- Hits 4488 4362 -126
+ Misses 223 221 -2
+ Partials 43 40 -3
Continue to review full report at Codecov.
|
94cc99b to
fefdb53
Compare
232bdad to
d2a33d0
Compare
|
Hello @jerbob, just checking in to see how you're doing. Do you need help with this PR? |
|
@jerbob do we need the migrations to move data over? We only ever run the app for a single event anyways. |
jchristgit
left a comment
There was a problem hiding this comment.
Jeremiah,
While I highly appreciate the amount of effort that has flown into this pull
request, in its current state, it is not possible to actually review the code,
as I am plagued with local setup errors. I understand it's hard to keep a pull
request of this size in sync with the master branch, but I cannot adjust half
the project when testing it locally. I've encountered a number of issues whilst
trying to set this up:
-
poetry.lockwas not working properly, and causedpoetryto crash with an
error. Runningpoetry lockfixed it. -
After building the project in
docker-composeand starting it, it crashed
multiple times. For the following reasons, in no particular order:- Unexpected indents
- Undefined imports
- Missing migrations
-
I tried to fix the missing imports by using
flake8, or at least find them,
butflake8also crashes out with an error, I assume due to a configuration
error:
flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "pylint" due
to cannot import name 'MergedConfigParser' from 'flake8.options.config' (...).I believe the majority of these problems is caused by the recent merge with
option -X ours. I understand it's annoying to fix a big merge conflict, but
perhaps we should roll the merge back, and try to resolve it one-by-one?
221a28b to
d2a33d0
Compare
|
Johannes, While I highly appreciate your need to check in on unfinished "Draft" PRs Your unsolicited code review on this "Draft" (not ready for a code review) You can find out more about "Draft" pull requests in this blog post: You can find out more about the etymology of the word "Draft" here: You can find out more about the etymology of the word "unsolicited" here: |
|
I'm sorry, Jeremiah. I will take my review down immediately, and implement |
|
Johannes, thanks |
|
😢 |
|
As a longtime fan of the RACTF backend, I'm sad to see this go. When I was a child, I loved learning about new developments of the RACTF As I grew older, my childlike fascination with the lack of updates on the pull Jeremiah, thank you for all your hard work. I can understand why you've chosen |

This PR contains a bunch of sweeping changes to the project's app names and scopes. The goal here is to get rid of any redundant apps, and merge any apps whose scopes intersect.