Skip to content

Conversation

@kotAPI
Copy link
Collaborator

@kotAPI kotAPI commented May 24, 2025

Summary by CodeRabbit

  • New Features
    • Added export support for a new ScrollArea component.
    • Enhanced ScrollArea with animated fast scrolling and a minimum thumb height.
    • Enabled continuous scrolling by holding down the scrollbar.
    • Introduced drag-to-scroll functionality for the scrollbar thumb.
  • Improvements
    • SandboxEditor now remembers dark mode preference using local storage.
    • ScrollArea stories now feature more scrollable content for better demonstration.
  • Style
    • Updated scrollbar and thumb colors, and improved hover effects for better visual feedback.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update enhances the ScrollArea UI component with smooth animated scrolling, drag support for the scroll thumb, and continuous scrolling when the scrollbar is held. It also updates the package export for ScrollArea, improves the SandboxEditor dark mode persistence, and refines related styles and story content for better demonstration and usability.

Changes

File(s) Change Summary
package.json Added export entry for ./ScrollArea pointing to the built component.
src/components/tools/SandboxEditor/SandboxEditor.tsx Dark mode state now initializes from and syncs to localStorage; container uses min-h-screen instead of h-screen.
src/components/ui/ScrollArea/fragments/ScrollAreaRoot.tsx Thumb height capped at 24px; added smooth animated scroll with fastScrollTo; updated scroll logic.
src/components/ui/ScrollArea/fragments/ScrollAreaScrollbar.tsx Added continuous scrolling on scrollbar hold using mouse events and interval timers.
src/components/ui/ScrollArea/fragments/ScrollAreaThumb.tsx Added drag support for scroll thumb with mouse tracking and scroll updates.
src/components/ui/ScrollArea/stories/ScrollArea.stories.tsx Story now renders repeated scrollable content blocks; removed fixed sizing classes.
styles/themes/components/scroll-area.scss Refined scrollbar and thumb styles, added hover states, nested thumb styling under scrollbar.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Scrollbar
    participant Thumb
    participant Viewport

    User->>Scrollbar: MouseDown (outside thumb)
    Scrollbar->>Viewport: Scroll (immediate)
    Note right of Scrollbar: After 300ms, starts interval
    User->>Scrollbar: Hold mouse
    Scrollbar->>Viewport: Scroll repeatedly (every 50ms)
    User->>Scrollbar: MouseUp/Leave
    Scrollbar-->>Viewport: Stop scrolling

    User->>Thumb: MouseDown (on thumb)
    Thumb->>Thumb: Record initial mouse Y and scrollTop
    User->>Thumb: MouseMove (drag)
    Thumb->>Viewport: Update scrollTop based on drag delta
    User->>Thumb: MouseUp
    Thumb->>Thumb: End drag, restore styles
Loading

Possibly related PRs

Suggested labels

automerge

Poem

A scroll so smooth, a thumb that glides,
Now drag, now hold—see how it rides!
With colors bright and stories long,
The ScrollArea sings a brand new song.
Dark mode remembers, styles refined,
Hooray for features so well-designed!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-24T11_04_22_376Z-debug-0.log


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a09913 and 05c158b.

📒 Files selected for processing (7)
  • package.json (1 hunks)
  • src/components/tools/SandboxEditor/SandboxEditor.tsx (1 hunks)
  • src/components/ui/ScrollArea/fragments/ScrollAreaRoot.tsx (2 hunks)
  • src/components/ui/ScrollArea/fragments/ScrollAreaScrollbar.tsx (1 hunks)
  • src/components/ui/ScrollArea/fragments/ScrollAreaThumb.tsx (1 hunks)
  • src/components/ui/ScrollArea/stories/ScrollArea.stories.tsx (1 hunks)
  • styles/themes/components/scroll-area.scss (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kotAPI kotAPI merged commit 11e51ba into main May 24, 2025
4 checks passed
@kotAPI kotAPI deleted the kotapi/scroll-area-scroll-improvements-part-2 branch May 24, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants