feat: collect online tools and references for offline-ready workflow#30
Conversation
💡 Codex ReviewFirst_two/bitnet_tools/analysis.py Line 42 in 329455d Unconditionally stripping commas causes locale-formatted decimals to be misread, so values like This command claims to collect optional dependency wheels, but ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Motivation
Description
resources/online_sources.jsonto declaretool_packagesandreference_urlsfor automated collection.scripts/collect_online_assets.pywhich downloads pip wheels to.online_assets/wheels, fetches reference HTML to.online_assets/references, and emits a structured report at.online_assets/meta/collection_report.json.ONLINE_RESOURCE_COLLECTION.mddocumenting the collector and update.gitignoreto exclude.online_assets/artifacts.scripts/prepare_online_bundle.shto build a local project wheel, attempt optional dependency downloads, archive an Ollama installer script if reachable, and write an offline usage guide under.offline_bundle/.tests/fixtures/and extendtests/test_analysis.pywithtest_to_float_normalizes_currency_comma_percent_parenthesesandtest_baseline_fixture_summaries_are_stableto assert numeric normalization and baseline behavior._to_floatinbitnet_tools/analysis.pyto strip common currency symbols, thousands separators, percent signs, and treat values in parentheses as negative.Testing
pytest -qand all tests passed (26 passed).python scripts/collect_online_assets.py, which saved.online_assets/meta/collection_report.jsonshowing successful downloads for configured pip packages and captured reference fetch failures (environment tunnel/proxy returned 403) in the report.python -m bitnet_tools.cli doctorto validate CLI diagnostics and confirm environment status (reportedollamanot found).Codex Task