Conversation
|
Hello, Import warningFont warning
|
|
Hi, Thank you so much for reviewing and sharing these details. I understand that the write-access tests failed due to permission restrictions, and that’s completely fine. I will take care of the linting issues and make sure the code fully aligns with the style guidelines mentioned here: https://radis.readthedocs.io/en/latest/dev/developer.html#code-style-and-linting I will also look into the remaining warnings from the latest ReadTheDocs build: https://app.readthedocs.org/projects/radis/builds/30600297/ Specifically, I will address: Thank you again for your guidance and patience — I really appreciate it. |
|
hi @minouHub |
minouHub
left a comment
There was a problem hiding this comment.
Still found a lot of warnings, see the latest build: https://app.readthedocs.org/projects/radis/builds/30630802/
Import warning
Now that you started, do you think you could catch the others at the start of the log? There also a bunch near line 800 of the log
Example:
File "/home/docs/checkouts/readthedocs.org/user_builds/radis/conda/889/lib/python3.13/site-packages/sphinx/ext/autodoc/_dynamic/_importer.py", line 131, in _import_from_module_and_path
module = _import_module(module_name, try_reload=True)
File "/home/docs/checkouts/readthedocs.org/user_builds/radis/conda/889/lib/python3.13/site-packages/sphinx/ext/autodoc/_dynamic/_importer.py", line 218, in _import_module
raise ModuleNotFoundError(msg, name=modname) # NoQA: TRY301
Font
This message is still often present.
findfont: Generic family 'sans-serif' not found because none of the following families were found: Helvetica, Bitstream Vera Sans, Lucida Grande, Verdana, Geneva, Lucid, Arial, Avant Garde, sans-serif
Many docutils warnings
There are a lot of warnings/errors that prevent proper identification of actual problems. Notably:
- ERROR: Unexpected section title.
- WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
- WARNING: Inline interpreted text or phrase reference start-string without end-string. [docutils]
- WARNING: Inline emphasis start-string without end-string.
- ERROR: Unexpected indentation.
- ERROR: Undefined substitution referenced: "m".
... and I'm probably missing a lot. Do you think there is an automated way (via AI maybe) to clean all the files from these minor issues?
| # sys.path.insert( | ||
| # 0, os.path.abspath("../radis") | ||
| # ) # Attempt to fix import errors for submodules |
There was a problem hiding this comment.
Is it useful to keep this comment?
|
|
||
| :orphan: | ||
|
|
||
| .. _sphx_glr_sg_execution_times: | ||
|
|
||
|
|
There was a problem hiding this comment.
Interesting summary but ... why do you keep this file orphan?
|
Hello, |
|
Hmm Yeah @minouHub |
|
Hello, |
|
Hello, |
|
Closed due to inactivity |
This pull request addresses the documentation build limitations described in #887. It enables compatibility with modern Sphinx and Docutils versions and significantly reduces build warnings.
Changes:
Relaxed Dependencies: Updated pyproject.toml to remove strict upper version bounds for sphinx (<8) and docutils (<0.19). The documentation now builds successfully with Sphinx 9.0.4 and Docutils 0.22.3.
Fixed Build Error: Disabled the sphinx_autodoc_defaultargs extension in docs/conf.py as it caused an "invalid signature" error with newer Sphinx versions.
Fixed Import Warnings: Added the inner radis package directory to sys.path in docs/conf.py. This resolved ~90 "Failed to import module" warnings where Sphinx could not locate submodules like radis.misc or radis.db.
Results:
Build is now successful with latest dependencies.
Build warnings reduced from 123 to 33.
Fixes #887