Skip to content

build(bicep-types-radius): bump tsp and deps#11565

Open
DariuszPorowski wants to merge 2 commits intomainfrom
dp/economic-tapir-maroon
Open

build(bicep-types-radius): bump tsp and deps#11565
DariuszPorowski wants to merge 2 commits intomainfrom
dp/economic-tapir-maroon

Conversation

@DariuszPorowski
Copy link
Copy Markdown
Member

Description

This pull request updates several development dependencies and tools to their latest versions to ensure compatibility, security, and access to new features. The main changes are version bumps for dependencies in both the root package.json and the hack/bicep-types-radius/src/generator/package.json.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #11530

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
@DariuszPorowski DariuszPorowski self-assigned this Apr 6, 2026
@DariuszPorowski DariuszPorowski linked an issue Apr 6, 2026 that may be closed by this pull request
4 tasks
Copilot AI review requested due to automatic review settings April 6, 2026 16:51
@DariuszPorowski DariuszPorowski requested review from a team as code owners April 6, 2026 16:51
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates JavaScript toolchain versions for the repo and the hack/bicep-types-radius generator, aiming to keep development dependencies current.

Changes:

  • Bump root packageManager pnpm version.
  • Update hack/bicep-types-radius/src/generator devDependencies, including TypeScript 6.x, ESLint, and yargs 18.
  • Regenerate the generator’s pnpm-lock.yaml to reflect the updated dependency graph.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
package.json Updates the pinned pnpm version via packageManager.
hack/bicep-types-radius/src/generator/package.json Bumps generator devDependencies (TS/ESLint/yargs/etc.).
hack/bicep-types-radius/src/generator/pnpm-lock.yaml Lockfile updates resulting from the dependency bumps.
Files not reviewed (1)
  • hack/bicep-types-radius/src/generator/pnpm-lock.yaml: Language not supported

Comment on lines 47 to +49
"ts-node": "^10.9.2",
"typescript": "^5.6.3",
"yargs": "^17.7.2"
"typescript": "^6.0.2",
"yargs": "^18.0.0"
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bumps the generator to TypeScript 6.0.2 and yargs 18.0.0, but the generator entrypoint still uses the pre-TS6 yargs default-import pattern (import yargs from 'yargs' and then chaining without calling yargs(process.argv.slice(2))/hideBin). With TS6+yargs, this commonly breaks CJS/ESM interop at compile-time or runtime. Either update the generator CLI code/tsconfig to the yargs 18-compatible usage, or keep TypeScript/yargs pinned to the last known working major versions.

Copilot uses AI. Check for mistakes.
@radius-functional-tests
Copy link
Copy Markdown

radius-functional-tests bot commented Apr 6, 2026

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 84f6b68
Unique ID func8a49cb2b81
Image tag pr-func8a49cb2b81
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8a49cb2b81
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8a49cb2b81
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func8a49cb2b81
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func8a49cb2b81
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8a49cb2b81
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Unit Tests

    2 files  ±0    415 suites  ±0   6m 46s ⏱️ +8s
4 872 tests ±0  4 870 ✅ ±0  2 💤 ±0  0 ❌ ±0 
5 774 runs  ±0  5 772 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 84f6b68. ± Comparison against base commit 2ea450a.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.40%. Comparing base (2ea450a) to head (84f6b68).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11565   +/-   ##
=======================================
  Coverage   51.40%   51.40%           
=======================================
  Files         699      699           
  Lines       44156    44156           
=======================================
  Hits        22698    22698           
  Misses      19291    19291           
  Partials     2167     2167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@willdavsmith willdavsmith self-requested a review April 6, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update TypeScript to 6.x in bicep-types-radius generator

3 participants