Removed experimentalFeaturesEnabled from bicepconfig.json created by rad init#11651
Conversation
Signed-off-by: Zach Casper <zachcasper@microsoft.com>
There was a problem hiding this comment.
Pull request overview
Updates the rad init application scaffolding in pkg/cli/setup/application.go to simplify the generated bicepconfig.json by removing the experimentalFeaturesEnabled.extensibility block.
Changes:
- Remove
experimentalFeaturesEnabled.extensibilityfrom the scaffoldedbicepconfig.jsontemplate.
Comments suppressed due to low confidence (1)
pkg/cli/setup/application.go:58
rad initwill now scaffold abicepconfig.jsonthat differs from other configs/examples in this repo (e.g., repo-rootbicepconfig.jsonand some test configs still includeexperimentalFeaturesEnabled.extensibility). If this flag is still needed for any supported Bicep versions, new projects may fail to build; if it’s no longer needed, consider updating those other configs/docs to keep guidance consistent with the scaffolded output.
bicepConfigTemplate = `{
"extensions": {
"radius": "br:biceptypes.azurecr.io/radius:%s",
"aws": "br:biceptypes.azurecr.io/aws:%s"
}
}`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11651 +/- ##
==========================================
+ Coverage 51.38% 51.40% +0.01%
==========================================
Files 699 699
Lines 44111 44111
==========================================
+ Hits 22668 22675 +7
+ Misses 19276 19273 -3
+ Partials 2167 2163 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
# Description Removes the deprecated `experimentalFeaturesEnabled.extensibility` block from generated `bicepconfig.json` content and related examples now that Bicep no longer requires it. This updates the functional test workflows, the Bicep install script, the CLI application setup template, and the contributor documentation so all emitted and documented configs are consistent. ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). Additional changes to #11651 Fixes: N/A ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes <!-- TaskRadio schema --> - [x] Not applicable <!-- TaskRadio schema --> - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] Yes <!-- TaskRadio design-pr --> - [x] Not applicable <!-- TaskRadio design-pr --> - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes <!-- TaskRadio design-review --> - [x] Not applicable <!-- TaskRadio design-review --> - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio samples-pr --> - [x] Not applicable <!-- TaskRadio samples-pr --> - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes <!-- TaskRadio docs-pr --> - [x] Not applicable <!-- TaskRadio docs-pr --> - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio recipes-pr --> - [x] Not applicable <!-- TaskRadio recipes-pr --> Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
This pull request makes a small change to the Bicep configuration template in
application.go. The main update is the removal of theexperimentalFeaturesEnabledsection, which previously enabled theextensibilityfeature. This simplifies the configuration and may indicate that the feature is no longer needed or is now enabled by default.# DescriptionType of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: