Dev container Dependabot fixes for docker-in-docker and go features#11930
Merged
Conversation
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Dependabot parsing for dev container feature references and makes the dev container post-create setup more reliable for global pnpm installs.
Changes:
- Pins dev container base image and feature references to explicit versions.
- Regenerates devcontainer lock entries for the updated feature pins.
- Configures pnpm global bin path during post-create before installing
cspell.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.devcontainer/devcontainer.json |
Pins base image, Go feature, and docker-in-docker feature versions. |
.devcontainer/devcontainer-lock.json |
Updates lock metadata to match the pinned feature references. |
.devcontainer/post-create.sh |
Ensures pnpm global bin directory exists and is on PATH before installing cspell. |
DariuszPorowski
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix broken Dependabot runs against the dev container configuration and unblock the post-create script when installing global
pnpmpackages.Dependabot was failing on the dev container because two feature references in
.devcontainer/devcontainer.jsonand.devcontainer/devcontainer-lock.jsonwere pinned to an empty version tag (ghcr.io/devcontainers/features/docker-in-docker:andghcr.io/devcontainers/features/go:). Dependabot cannot parse an empty version and the run errors out. Example failing run: https://github.com/radius-project/radius/actions/runs/26043583065/job/76561626915Changes:
.devcontainer/devcontainer.jsonghcr.io/devcontainers/features/goto major version1.ghcr.io/devcontainers/features/docker-in-dockerto3.0.0(latest stable major).mcr.microsoft.com/devcontainers/base:ubuntutomcr.microsoft.com/devcontainers/base:ubuntu-24.04so the base image is also explicitly versioned and trackable by Dependabot..devcontainer/devcontainer-lock.json.devcontainer/post-create.shPNPM_HOMEand the pnpm global bin directory exist and are onPATHbefore runningpnpm add -g cspell. Without this,pnpm setuponly updates shell rc files for future sessions, causing the global install in the post-create script to fail.Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
eng/design-notes/in this repository, if new APIs are being introduced.