ci(gh-token-action): use client-id instead of app-id#11968
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates Radius GitHub Actions workflows to use the GitHub App client-id input (instead of app-id) when generating installation tokens via actions/create-github-app-token, aligning token generation with GitHub App client IDs across CI and automation workflows.
Changes:
- Replaced
app-idwithclient-idforactions/create-github-app-tokenusage across multiple workflows. - Removed now-unused environment variables that previously held App IDs.
- Minor whitespace/formatting cleanup in
long-running-azure.yaml.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/triage-bot.yaml | Switch triage bot token generation from app-id to client-id. |
| .github/workflows/release.yaml | Update release workflow App token generation to use client-id. |
| .github/workflows/publish-de-image.yaml | Update publisher bot token generation to use client-id. |
| .github/workflows/long-running-azure.yaml | Update functional test App token generation to use client-id; remove obsolete env var and tidy formatting. |
| .github/workflows/functional-test-cloud.yaml | Update functional test App token generation to use client-id; remove obsolete env var. |
| .github/workflows/build.yaml | Update build workflow App token generation to use client-id. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11968 +/- ##
==========================================
- Coverage 51.82% 51.81% -0.02%
==========================================
Files 728 728
Lines 45960 45960
==========================================
- Hits 23821 23815 -6
- Misses 19869 19872 +3
- Partials 2270 2273 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DariuszPorowski
force-pushed
the
dp/asleep-primate-gold
branch
from
1a38019 to
def1030
Compare
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
DariuszPorowski
force-pushed
the
dp/asleep-primate-gold
branch
from
def1030 to
e8de56b
Compare
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates several GitHub Actions workflow files to use
client-idinstead ofapp-idwhen generating GitHub App tokens with theactions/create-github-app-tokenaction.Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
eng/design-notes/in this repository, if new APIs are being introduced.