Skip to content

Volumes managed#1241

Merged
vinayada1 merged 13 commits into
radius-project:mainfrom
vinayada1:volumes-managed
Oct 28, 2021
Merged

Volumes managed#1241
vinayada1 merged 13 commits into
radius-project:mainfrom
vinayada1:volumes-managed

Conversation

@vinayada1
Copy link
Copy Markdown
Contributor

@vinayada1 vinayada1 commented Oct 8, 2021

Changes for managed volumes

@vinayada1 vinayada1 requested a review from a team as a code owner October 8, 2021 22:24
vinayada1
vinayada1 commented Oct 8, 2021
View reviewed changes
Comment thread pkg/renderers/containerv1alpha3/render.go
kachawla
kachawla reviewed Oct 12, 2021
View reviewed changes
Comment thread pkg/renderers/azurefilesharev1alpha3/render.go
@kachawla kachawla mentioned this pull request Oct 12, 2021
Merged
jkotalik
jkotalik reviewed Oct 12, 2021
View reviewed changes
Comment thread pkg/azure/azresources/types.go
kachawla
kachawla reviewed Oct 12, 2021
View reviewed changes
Comment thread pkg/handlers/azure_fileshare.go Outdated
Comment thread pkg/handlers/azure_fileshare.go Outdated
kachawla
kachawla reviewed Oct 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kachawla kachawla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the parts that I think are addition on top of #1171. Will wait for it to be rebased with that to do another pass.

Comment thread pkg/handlers/azure_fileshare_storageaccount.go Outdated
kachawla
kachawla reviewed Oct 22, 2021
View reviewed changes
Comment thread pkg/handlers/azure_fileshare.go Outdated
Comment thread pkg/handlers/azure_fileshare.go Outdated
Comment thread pkg/handlers/azure_fileshare.go Outdated
Comment thread pkg/handlers/azure_fileshare.go Outdated
kachawla
kachawla reviewed Oct 22, 2021
View reviewed changes
Comment thread pkg/handlers/azure_fileshare.go Outdated
Comment thread pkg/handlers/azure_fileshare_storageaccount.go Outdated
Comment thread pkg/renderers/azurefilesharev1alpha3/render.go
Comment thread pkg/renderers/azurefilesharev1alpha3/types.go Outdated
jkotalik
jkotalik reviewed Oct 25, 2021
View reviewed changes
Comment thread pkg/handlers/azure_fileshare.go Outdated
jkotalik
jkotalik reviewed Oct 25, 2021
View reviewed changes
Comment thread pkg/handlers/azure_fileshare.go Outdated
jkotalik
jkotalik reviewed Oct 25, 2021
View reviewed changes
Comment thread pkg/renderers/azurefilesharev1alpha3/render.go
jkotalik
jkotalik reviewed Oct 25, 2021
View reviewed changes
Comment thread test/functional/azure/resources/container/container_test.go
jkotalik
jkotalik reviewed Oct 27, 2021
View reviewed changes
Comment thread pkg/handlers/azure_fileshare.go Outdated
@vinayada1 vinayada1 merged commit b2fea16 into radius-project:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kachawla kachawla kachawla left review comments

+1 more reviewer

@jkotalik jkotalik jkotalik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vinayada1 @jkotalik @kachawla