Audit & optimize repo settings for public launch#7
Merged
dhilgaertner merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
Switch license from Apache 2.0 to MIT, add community health files (CODEOWNERS, issue/PR templates), configure Renovate for dependency updates, and add kubelinter to CI pipeline. Closes #5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Lint only our own templates (not postgresql subchart) and exclude checks for resource limits, read-only root fs, and latest tags that don't apply to init containers and test pods in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dgershman
approved these changes
Mar 9, 2026
Collaborator
dgershman
left a comment
There was a problem hiding this comment.
Code & Security Review
Critical Issues
None.
Security Review
Strengths:
- License change from Apache 2.0 to MIT is clean and valid (Copyright 2025 Radius Method)
- Issue templates remind users to redact secrets in bug reports (
.github/ISSUE_TEMPLATE/bug_report.yml:29) - kubelinter addition catches Kubernetes security misconfigurations in CI
- CODEOWNERS ensures PRs get reviewed by
@radiusmethod/engineering
Concerns:
- kubelinter install uses
/releases/latest(.github/workflows/lint.yaml:31) — this downloads whatever the latest version is at runtime, which means builds aren't reproducible and a compromised release could affect CI. Consider pinning to a specific version (e.g.v0.7.2) or using the official stackrox/kube-linter-action GitHub Action with a pinned version. - kube-linter exclusions are broad (
.kube-linter.yaml:4-8) — excludingrun-as-non-root,no-read-only-root-fs, andlatest-tagglobally rather than per-resource means these checks won't fire for any resource, including the main deployment container. The comment says "init containers and test pods" but the exclusions apply chart-wide. Consider scoping exclusions to specific objects if possible, or at least updating the comment to reflect the actual scope. - kubelinter binary downloaded over HTTPS without checksum verification (
.github/workflows/lint.yaml:31) — no integrity check on the downloaded binary. Lower risk since it's from GitHub releases, but worth noting.
Code Quality
- Issue templates are well-structured with appropriate required fields
- PR template includes useful checklist (chart version bump, docs update, changelog)
- Renovate config is minimal and uses recommended defaults — good
- Removing the Code of Conduct section from CONTRIBUTING.md is fine (it was just a one-liner)
- README.md license reference updated to match — consistent
Summary Table
| Priority | Issue |
|---|---|
| 🟡 Yellow | kubelinter installed from /latest — pin version for reproducible builds |
| 🟡 Yellow | kube-linter exclusions are chart-wide, not scoped to init containers as comment suggests |
| 🟢 Green | No checksum verification on kubelinter binary download |
Recommendation: Approve — This is a solid repo hygiene PR. The kubelinter version pinning is worth addressing in a follow-up but isn't blocking. All changes are well-organized and appropriate for a public launch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
* @radiusmethod/engineering)Closes #5
Test plan
helm lint . --set citadel.secretKey=testpasseshelm template citadel . --set citadel.secretKey=testrenders correctly🤖 Generated with Claude Code