Quality Pass: Configuration & Settings

[dhilgaertner]

Parent: #53

Scope

Application configuration model, settings persistence, settings UI (General/Workspaces/Notifications tabs), workspace management, and sidebar display preferences.

• Refactoring — identify and address code quality improvements
• Documentation — ensure adequate inline and user-facing docs
• Code Review — thorough review for correctness, edge cases, security
• Testing — add/improve tests for key functionality

Key Files

• Packages/CrowCore/Sources/CrowCore/Models/AppConfig.swift — AppConfig, WorkspaceInfo, ConfigDefaults, SidebarSettings
• Packages/CrowPersistence/Sources/CrowPersistence/ConfigStore.swift — config I/O at {devRoot}/.claude/config.json
• Packages/CrowUI/Sources/CrowUI/SettingsView.swift — three-tab settings window
• Packages/CrowUI/Sources/CrowUI/WorkspaceEditorView.swift — workspace add/edit form
• Packages/CrowUI/Sources/CrowUI/NotificationSettingsView.swift — per-event notification config

Areas of Interest

• Config schema (workspaces, defaults, notifications, sidebar settings)
• Migration from CMUX and legacy "rm-ai-ide" configs
• Workspace config (provider, CLI, host, alwaysInclude repos)
• Default values and fallback behavior
• Config validation and error handling