Add double-click rename on master session rows#416
Merged
Conversation
Mirror the right-click → Rename action so double-clicking an extra Manager row in the sidebar enters inline-rename mode (cursor in field, Enter/blur commits, Escape cancels). Implemented as a simultaneous double-tap gesture so the existing single-click selection still fires. Only ManagerSessionRow gains the gesture — the primary manager row and work-session rows are unchanged, matching where right-click → Rename is shown today. Closes #415 🐦⬛ Generated with Claude Code, orchestrated by Crow Co-Authored-By: Claude <noreply@anthropic.com> Crow-Session: 59082D52-7CD2-4E31-AEA7-0B6343CEF04B
dhilgaertner
approved these changes
Jun 3, 2026
Contributor
dhilgaertner
left a comment
There was a problem hiding this comment.
Code & Security Review
Critical Issues
None.
Security Review
Strengths:
- Pure local SwiftUI gesture change — no authentication, input parsing, network, or persistence surface touched.
- Rename ultimately flows through the existing
appState.onRenameSession?path with the sametrimmingCharacters/ empty-guard logic incommitRename(); no new trust boundary introduced.
Concerns:
- None.
Code Quality
- Correct scoping (verified). The double-click gesture lives on
ManagerSessionRow, andeditingManagerIDis bound only to that row (SessionListView.swift:84) — the single row type that already exposes the "Rename" context-menu item (SessionListView.swift:88-93). The primary manager row (ManagerReviewsAllowListRow) and work-session rows (SessionRow) never receive the gesture, so the no-regression claim holds. - Sound mechanism.
.simultaneousGesture(TapGesture(count: 2))preserves the Button's single-click selection while the second click setseditingSessionID = session.id. The existing.onChange(of: editingSessionID)(SessionListView.swift:494-499) seedseditingNameand raises focus, and Enter/blur/Escape reuse the established commit/cancel machinery — no duplicated logic. - Build note:
swift buildfails in this review worktree only because the localGhosttyKit.xcframeworkbinary artifact isn't checked out — an environmental issue unrelated to this 5-line diff (which touchesSessionListView.swiftexclusively).
Summary Table
| Color | Meaning | Verdict effect |
|---|---|---|
| Red | Must fix | Request changes |
| Yellow | Should fix | Request changes |
| Green | Consider | Approve allowed |
Recommendation: Approve — driven by [0 Red, 0 Yellow, 0 Green] findings. Minimal, correctly scoped change that cleanly reuses the existing inline-rename machinery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.simultaneousGesture(TapGesture(count: 2))onManagerSessionRowso single-click selection still fires; the second click flipseditingSessionID = session.idto reuse the existing rename machinery (focus, Enter/blur commit, Escape cancel).Test plan
Closes #415
🐦⬛ Generated with Claude Code, orchestrated by Crow