Skip to content

Fix session not completing when linked issue is closed#83

Merged
dhilgaertner merged 1 commit intomainfrom
feature/crow-77-complete-on-issue-close
Apr 5, 2026
Merged

Fix session not completing when linked issue is closed#83
dhilgaertner merged 1 commit intomainfrom
feature/crow-77-complete-on-issue-close

Conversation

@dhilgaertner
Copy link
Copy Markdown
Contributor

@dhilgaertner dhilgaertner commented Apr 5, 2026

Summary

  • Filter out recently-closed "done" issues before passing to autoCompleteFinishedSessions, so closed issues are correctly detected as no longer open
  • Expand candidate sessions to include paused and inReview statuses (not just active), so issue closure completes the session regardless of its current state

Closes #77

Test plan

  • Create a session linked to a GitHub issue (no PR)
  • Close the issue on GitHub
  • Wait for the 60-second poll cycle or trigger a refresh
  • Verify the session transitions to completed
  • Repeat with a session in paused and inReview states

🤖 Generated with Claude Code

The `autoCompleteFinishedSessions` method received all issues including
recently-closed "done" issues, so closed issue URLs were in the "open"
set and the check was skipped. Filter to only truly-open issues before
passing them in. Also expand candidate sessions to include paused and
inReview statuses so closing an issue completes the session regardless
of its current non-completed state.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@dhilgaertner dhilgaertner force-pushed the feature/crow-77-complete-on-issue-close branch from 84d891f to 09728d9 Compare April 5, 2026 21:04
@dhilgaertner dhilgaertner merged commit a46eaa6 into main Apr 5, 2026
2 checks passed
@dhilgaertner dhilgaertner deleted the feature/crow-77-complete-on-issue-close branch April 5, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session should move to completed when associated issue is closed

1 participant