[Select] feature: make autoScroll interval configurable #3269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshelsil
requested review from
StephenHaney,
chaance,
hadihallak and
lucasmotta
as code owners
eshelsil
changed the title
|
hey @eshelsil — we're running into the same need to control scroll speed. Any plans on getting this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Currently, the autoScroll interval in the scroll buttons is hardcoded to 50ms, which makes it difficult to adjust the scrolling speed for specific use cases.
Solution
This change makes the autoScroll interval configurable by allowing a new optional prop,
autoScrollInterval, to be passed. The interval defaults to 50ms to maintain backward compatibility.Tests
Storybook
WithCustomAutoScrollIntervalwith different values.Backward Compatibility
This change is fully backward-compatible as the
autoScrollIntervaldefaults to 50ms, matching the previous implementation.Related Issues
Closes #2829