[NavigationMenu] Add Portal #3272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrdassouli
requested review from
StephenHaney,
chaance,
hadihallak and
lucasmotta
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overview
This pull request introduces the Portal feature to the NavigationMenu component (in response to the #3159 issue), addressing common issues caused by overflow: hidden styles in parent containers. By rendering NavigationMenuContent in a Portal, this change ensures that dropdowns or menus within the component are not clipped or hidden, particularly in fixed-height navigation bars or headers with hidden overflow.
Key Changes
This change aligns NavigationMenu with other primitives like Dialog and DropdownMenu, improving usability and ensuring consistency. It benefits all users working with headers or navigation bars with constrained overflow properties, ensuring dropdowns display correctly without additional configuration.
Impact
Users: Enhances usability for any developers integrating NavigationMenu in constrained layouts.
Consistency: Brings feature parity with similar Radix UI primitives.