Impl for Programmatic JSON deserializer#747
Merged
jakrawcz-rdx merged 1 commit intofeature/browse_apifrom Dec 1, 2023
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Base automatically changed from
feature/browse_blueprint_info
to
feature/browse_api
December 1, 2023 10:34
Contributor
Author
|
I am merging all these PRs into long-lived |
jakrawcz-rdx
added a commit
that referenced
this pull request
Dec 1, 2023
⚠️ This builds on top of #747 (relies on the programmatic JSON deserialization support introduced there) and ultimately wants to merge into `feature/browse_api` _(not `develop`!)_. This implements [https://radixdlt.atlassian.net/wiki/spaces/RPNV1/pages/3189211214/RNP-12+-+Browse+API+sub-API+within+Core+API#3.-Blueprint-Details .](https://radixdlt.atlassian.net/wiki/spaces/RPNV1/pages/3189211214/RNP-12+-+Browse+API+sub-API+within+Core+API#8.-KVStore-Collection-Lookup) . (with all the infra already provided by the previous Browse API PRs, this one is actually trivial) (the only other remaining endpoint, `/browse/object/collection/entry`, should be trivial based on this one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature/browse_api(notdevelop!).This is in the "Browse API" PR-chain, but actually it is a pretty generic feature:
Note: The serializer facade is used right away, but the deserializer is currently unused (and rightfully produces warnings) [except in tests]; it will soon be used by Browse API's "lookup kv store/collection" endpoints.