Deps Upgrade #22
Merged
Deps Upgrade #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jameswylie
commented
Mar 19, 2025
jameswylie
commented
- Resolves all flagged vulnerability related warnings (package manager).
- Notably resolves high severity Secp256k1 vulnerability (even though not fully utilised within the RET, dependent packages will no longer flag warnings): https://hacken.io/insights/secure-ecdh/
…g npm vulnerabilities.
Closed
dynst
reviewed
Jun 30, 2025
| "registry": "https://registry.npmjs.org" | ||
| }, | ||
| "overrides": { | ||
| "elliptic": "6.5.7" |
There was a problem hiding this comment.
Suggested change
| "elliptic": "6.5.7" | |
| "elliptic": "^6.6.1" |
While updating dependencies, it'd be good to also update or undo 852a6ad instead of continuing to force an outdated version with known vulnerabilities.
dynst
reviewed
Jun 30, 2025
Comment on lines
+59
to
+62
| "@noble/ed25519": "2.2.3", | ||
| "@noble/hashes": "1.7.1", | ||
| "@types/secp256k1": "4.0.6", | ||
| "@types/secure-random": "1.1.3", |
There was a problem hiding this comment.
Suggested change
| "@noble/ed25519": "2.2.3", | |
| "@noble/hashes": "1.7.1", | |
| "@types/secp256k1": "4.0.6", | |
| "@types/secure-random": "1.1.3", | |
| "@noble/ed25519": "^2.2.3", | |
| "@noble/hashes": "^1.7.1", | |
| "@types/secp256k1": "^4.0.6", | |
| "@types/secure-random": "^1.1.3", |
dynst
reviewed
Jun 30, 2025
Comment on lines
+64
to
+66
| "change-case": "5.4.4", | ||
| "decimal.js": "10.5.0", | ||
| "reflect-metadata": "0.2.2", |
There was a problem hiding this comment.
Suggested change
| "change-case": "5.4.4", | |
| "decimal.js": "10.5.0", | |
| "reflect-metadata": "0.2.2", | |
| "change-case": "^5.4.4", | |
| "decimal.js": "^10.5.0", | |
| "reflect-metadata": "^0.2.2", |
dynst
reviewed
Jun 30, 2025
| "vite": "4.2.1", | ||
| "vitest": "0.29.8" | ||
| "@rollup/plugin-wasm": "6.2.2", | ||
| "@types/node": "22.13.10", |
There was a problem hiding this comment.
Suggested change
| "@types/node": "22.13.10", | |
| "@types/node": ">=22.13.10", |
dynst
reviewed
Jun 30, 2025
dynst
left a comment
dynst
left a comment
There was a problem hiding this comment.
While they're being updated, adding carets to the dependency versions would be great, too.
Merged
gguuttss
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.