Merged
Conversation
I've updated the test to assert what I believe it was trying to assert before. Without this change, the CSS is invalid so it's unclear what behavior we're demonstrating. PR Close #64036
See associated pull request for more information. PR Close #64195
See associated pull request for more information. PR Close #64265
See associated pull request for more information. PR Close #64284
Instead of the non-public primitive one. PR Close #64247
…ters (#64130) Currently we produce the string value of a defer `on` trigger by concatenating the string values of all of its tokens. This ends up ignoring whitespaces which in turn throws off source spans. These changes switch to producing the string by taking the text between the start and end tokens, as well as tracking the start index. PR Close #64130
) Updates the template parser and AST to capture a second object literal parameter on `viewport` triggers. PR Close #64130
Updates the template type checker to check the options of the `viewport` trigger against `IntersectionObserver`. PR Close #64130
) Updates the template pipeline to support options for the `viewport` triggers. PR Close #64130
…#64130) Adds support for customizing the `IntersectionObserver` options for the `on viewport`, `prefetch on viewport` and `hydrate on viewport` triggers. Note that the options need to be a static object literal, e.g. `@defer (on viewport(trigger, {rootMargin: '123px'})`. Fixes #52799. PR Close #64130
Updates the docs to mention the new options for the `viewport` trigger. PR Close #64130
See associated pull request for more information. PR Close #64282
See associated pull request for more information. PR Close #64285
The `@angular/language-service` package was not needed for integration tests or benchmarks. Removing this dependency simplifies the build configuration. PR Close #64306
This commit updates the VSCode Angular Language Service extension to use the `@angular/language-service` package built from source within the workspace, rather than a version downloaded from npm. This change simplifies development and testing by ensuring the extension always uses the latest code from the local repository. The Bazel build configuration, VSCode launch settings, and e2e tests have been updated to reflect this change. PR Close #64306
This change updates the build configuration to include the @angular/language-server package in the standard framework release output. By integrating it into the release train, we ensure that it is versioned and published consistently with the rest of the Angular framework. PR Close #64306
This commit migrates the vscode-ng-language-service to use the in-repo `ts_project` macro, which has strict dependency checking enabled. This improves build-time dependency validation and helps ensure that all dependencies are explicitly declared. As part of this change, redundant `tsconfig.json` files have been removed in favor of a centralized configuration, and `jasmine_test` rules have been updated to the standard macro. A minor code adjustment in `server/src/session.ts` was also made to improve error handling. PR Close #64306
Reworks the logic that tracks the decorator metadata for members to do so using the output AST, rather than wrapping the TypeScript AST. This makes it easier to programmatically generate new members that weren't part of the TypeScript AST before. PR Close #63957
Adds the member decorators to the map of exposed compiler symbols. PR Close #63957
Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment. These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well. Fixes #57944. PR Close #63957
The `xvfb.start()` and `xvfb.stop()` methods are asynchronous but were being called synchronously. This can lead to race conditions where the tests start running before the virtual frame buffer is fully initialized, or the process exits before it's fully stopped. This commit promisifies the `start` and `stop` methods to ensure they are properly awaited, making the e2e test setup more robust. PR Close #64310
…r traversals (#64299) When the scroll position is being restored, this change upates the behavior to use 'instant' rather than the default 'auto', which will be whatever the browser behavior is for 'window.scrollTo'. The 'smooth' behavior does not match how browsers behavior when performing a traversal navigation for MPAs, which is 'instant'. related to #58258 PR Close #64299
Fixes a test that didn't exist when the recent metadata PR was created. PR Close #64319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )