Merged
Conversation
From my investigation what I know for sure: - when the graph pans or zooms it updates the transform property on the g element, which in turn causes the browser to repaint the visible space in the g element - stroke-dasharray is the cause of major performance issues in large graphs. What I suspect: - When the g element repaints, it also has to repaint all of the child svg elements. When the dashed line path svgs repaint, the stroke-dasharray calculation is not GPU accelerated, but instead occurs on the CPU, causing extreme lag whenever the svg graph is panned or zoomed. Temporary solution: remove this dashed edge functionality. We can investigate alternatives for communicated that a path is lazy loaded. Future long term solution: migrate to canvas based graph renderer for router tree and injector graph. PR Close #64532
This package json was missed when we recently bumped ts versions. PR Close #64543
See associated pull request for more information. PR Close #64533
See associated pull request for more information. PR Close #64514
See associated pull request for more information. PR Close #64544
This further simplifies the `loadComponent` logic in the Router by using the promise returned from the config loader directly instead of converting it to an observable. PR Close #64450
…races (#64392) This change omits the injection of the template syntaxes inside any existing block scope. The injection is not needed because the template and expression scopes are included explicitly as patterns where appropriate under the template-blocks definitions. This change prevents the interpolation curly braces from superseding the match for the open curly of the block body. This issue also happens with ICUs (#62697), but those do not have any named scopes to exclude as of today. fixes angular/vscode-ng-language-service#1991 PR Close #64392
Moves the `SimpleChange` and lifecycle hook interfaces so that they can import other symbols from `core`. PR Close #64535
Currently it's easy to make a mistake when accessing properties on `SimpleChanges`, because the keys aren't typed. These changes add an optional generic to the interface so that users can get a compilation error if they make a typo. A few things to note: 1. The generic argument is optional and we revert to the old behavior if one isn't passed for backwards compatibility. 2. All of the keys are optional, because they aren't guaranteed to be present for any `ngOnChanges` invocation. 3. We unwrap the values of input signals to match the behavior at runtime. Fixes #17560. PR Close #64535
…ers (#64449) Previously, query parameters passed to `router.createUrlTree` were simply converted to strings. This meant that any custom serialization logic in a custom `UrlSerializer` was not applied. This could lead to inconsistencies between navigations triggered from the URL bar (which are parsed by the serializer) and navigations triggered programmatically. This change ensures that query parameters are normalized using the provided `UrlSerializer`. The values are serialized and then parsed to ensure they are in the same format as if they had come from a URL. This allows custom serializers to handle complex objects in query parameters consistently. Fixes #47307 PR Close #64449
Use a string union type instead of a generic string. PR Close #64127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )