-
Notifications
You must be signed in to change notification settings - Fork 97
feat: add Rock4 products information #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments (3)
- i18n/en/docusaurus-plugin-content-docs/current/rock4/products.md (26-26) Both ROCK 4SE and ROCK 4A/B Plus link to the same details page (`/rock4/rock4ab-se`). Should these products have separate documentation pages?
-
docs/rock4/products.md (20-20)
There's a formatting issue in the ROCK 4 SE table - the '详情' column has an extra space after the dash which breaks the table alignment. Please fix this by removing the extra space:
| -------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------ | - i18n/en/docusaurus-plugin-content-docs/current/rock4/products.md (25-25) The formatting in the ROCK 4 SE table has inconsistent alignment. The 'Particulars' column contains `---------------- ` with extra spaces, while other tables use proper alignment.
💡 To request another review, post a new comment with "/windsurf-review".
i18n/en/docusaurus-plugin-content-docs/current/rock4/products.md
Outdated
Show resolved
Hide resolved
8f7c8db to
5fa8fef
Compare
|
/windsurf-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
i18n/en/docusaurus-plugin-content-docs/current/rock4/products.md
Outdated
Show resolved
Hide resolved
i18n/en/docusaurus-plugin-content-docs/current/rock4/products.md
Outdated
Show resolved
Hide resolved
jack-ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个原来的 table 是不能对齐的,把他们合并到一张大 table,保持对齐。
5fa8fef to
5b0ab0a
Compare
5b0ab0a to
5ffd0c9
Compare
done |
Description of changes