Skip to content

feat: add search functionality for lists and tips#260

Merged
rafaover merged 3 commits intorafaover:developfrom
abdulrahman-nisar:master
Jan 15, 2026
Merged

feat: add search functionality for lists and tips#260
rafaover merged 3 commits intorafaover:developfrom
abdulrahman-nisar:master

Conversation

@abdulrahman-nisar
Copy link
Copy Markdown
Contributor

Why:

Implementing basic search functionality to improve content discoverability.

What's being changed:

Added search capabilities for:

  1. Searching lists by name.
  2. Searching tips within a specific list by amount.

Changes include database queries, repository methods, UI components, and ViewModel updates.

@rafaover rafaover self-requested a review January 15, 2026 04:46
@rafaover rafaover self-assigned this Jan 15, 2026
@rafaover
Copy link
Copy Markdown
Owner

Pull request to the develop branch. It's updated.

@rafaover rafaover closed this Jan 15, 2026
@abdulrahman-nisar
Copy link
Copy Markdown
Contributor Author

Hi @rafaover,

Thank you for reviewing my PR! I noticed it was closed but I don't see the changes merged into the develop branch.

Could you please clarify:

  1. Were the changes incorporated in a different way?
  2. Are there any modifications needed for this feature to be accepted?
  3. If the feature won't be included, could you share the reasoning so I can learn for future contributions?

I'm happy to make any necessary adjustments or rebase if needed.

Thanks for maintaining this project!

@rafaover rafaover reopened this Jan 15, 2026
@rafaover rafaover changed the base branch from master to develop January 15, 2026 12:45
@rafaover
Copy link
Copy Markdown
Owner

It was my mistake. I just updated the PR and goiong to merge to Develop to test it. Thank you for the contribution. :) Any idea that you want to try, feel free.

@rafaover rafaover added the enhancement Improvement of a feature label Jan 15, 2026
Copy link
Copy Markdown
Owner

@rafaover rafaover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@rafaover rafaover merged commit dc2b454 into rafaover:develop Jan 15, 2026
@abdulrahman-nisar
Copy link
Copy Markdown
Contributor Author

Thank you @rafaover!

I appreciate you merging this PR. I was initially confused when I saw it was closed, but I'm glad to see it's now merged into the develop branch!

If there are any follow-up improvements needed or other features you'd like help with, feel free to let me know. I'm happy to contribute more to MatipV2!

Thanks for maintaining this great project! 👍

@rafaover
Copy link
Copy Markdown
Owner

rafaover commented Feb 9, 2026

No problems, mate. I was busy with something else, but knowing that I'm coming back to this one to improve more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement of a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants