Skip to content

Conversation

@alex-s-gardner
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.64%. Comparing base (f1c4b75) to head (455deb6).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
+ Coverage   82.89%   83.64%   +0.74%     
==========================================
  Files          58       68      +10     
  Lines        5425     5484      +59     
==========================================
+ Hits         4497     4587      +90     
+ Misses        928      897      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rafaqz
Copy link
Owner

rafaqz commented Oct 31, 2025

Do we need to update any of the XDatasets packages at the same time?

Seems like we dont

@rafaqz rafaqz merged commit f9ad2ec into rafaqz:main Oct 31, 2025
5 of 6 checks passed
@tiemvanderdeure
Copy link
Collaborator

Wait why do we allow CDM 0.2.3 but not CDM 0.3?

@rafaqz
Copy link
Owner

rafaqz commented Oct 31, 2025

Right I missed that, it doesnt make sense

@tiemvanderdeure
Copy link
Collaborator

I think we can just keep 0.3? We haven't removed any of the wrapping to make DiskArrays work so 0.3 should still be fine. And the breakages in CDM 0.4 don't affect this package at all

@alex-s-gardner
Copy link
Contributor Author

alex-s-gardner commented Oct 31, 2025

I got a conflict if I loaded NCDatatsets before Rasters.. hence the bump

@tiemvanderdeure
Copy link
Collaborator

yeah the bump is good! But we can keep the CDM 0.3 compat I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants