Skip to content

Account for failed downloads in the finish_stage of download_or_update #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Account for failed downloads in the finish_stage of download_or_update #154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdce44a
made finish message prettier
noobLue Apr 11, 2021
262a9f8
Include number of failed downloads in finish stage
noobLue Apr 11, 2021
db5d0e3
added finish message for when all exercises are already up-to-date
noobLue Apr 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions tmc-langs/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,14 +411,26 @@ pub fn download_or_update_course_exercises(
};
}

progress_reporter::finish_stage::<ClientUpdateData>(
let finish_message = if failed.is_empty() {
if successful.len() == 0 && exercises_len == 0 {
"Exercises are already up-to-date!".to_string()
} else {
format!(
"Successfully downloaded {} out of {} exercises.",
successful.len(),
exercises_len
)
}
} else {
format!(
"Successfully downloaded {} out of {} exercises.",
"Downloaded {} out of {} exercises ({} failed)",
successful.len(),
exercises_len
),
None,
);
exercises_len,
failed.len(),
)
};

progress_reporter::finish_stage::<ClientUpdateData>(finish_message, None);

let downloaded = successful
.into_iter()
Expand Down