Skip to content

Tag output data adjacently #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Heliozoa merged 1 commit into from
Jan 27, 2021
Merged

Tag output data adjacently #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions tmc-langs-cli/api/output-data-download-or-update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,26 @@
"result": "executed-command",
"data": {
"output-data-kind": "exercise-download",
"downloaded": [
{
"course-slug": "some course",
"exercise-slug": "some exercise",
"path": "some path"
},
{
"course-slug": "some course",
"exercise-slug": "another exercise",
"path": "another path"
}
],
"skipped": [
{
"course-slug": "another course",
"exercise-slug": "some skipped exercise",
"path": "third path"
}
]
"output-data": {
"downloaded": [
{
"course-slug": "some course",
"exercise-slug": "some exercise",
"path": "some path"
},
{
"course-slug": "some course",
"exercise-slug": "another exercise",
"path": "another path"
}
],
"skipped": [
{
"course-slug": "another course",
"exercise-slug": "some skipped exercise",
"path": "third path"
}
]
}
}
}
12 changes: 7 additions & 5 deletions tmc-langs-cli/api/output-data-error.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@
"result": "error",
"data": {
"output-data-kind": "error",
"kind": "generic",
"trace": [
"trace 1",
"trace 2"
]
"output-data": {
"kind": "generic",
"trace": [
"trace 1",
"trace 2"
]
}
}
}
2 changes: 1 addition & 1 deletion tmc-langs-cli/src/output.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub struct OutputData {

#[derive(Debug, Serialize)]
#[serde(rename_all = "kebab-case")]
#[serde(tag = "output-data-kind")]
#[serde(tag = "output-data-kind", content = "output-data")]
pub enum Data {
Error { kind: Kind, trace: Vec<String> },
Validation(StyleValidationResult),
Expand Down