selftest: Fix test_rglob_error depending on host system too much - #133
Merged
Conversation
test_rglob_error made an assumption about files present in sysfs which turned out to not be true everywhere [1]. Fix this by instead writing the testcase against a synthetic file structure which will look the same no matter what system it runs on. [1]: #132 Signed-off-by: Rahix <rahix@rahix.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 62.47% 62.47%
=======================================
Files 53 53
Lines 3765 3765
=======================================
Hits 2352 2352
Misses 1413 1413 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_rglob_error made an assumption about files present in sysfs which turned out to not be true everywhere (see #132).
Fix this by instead writing the testcase against a synthetic file structure which will look the same no matter what system it runs on.
Fixes #132.