Factor config func#9
Merged
Merged
Conversation
rahulgrit
force-pushed
the
factor-config-func
branch
6 times, most recently
from
d49bb48 to
2c05444
Compare
…ing sample time of server status
`DAOS_COND_DKEY_INSERT` was inappropriately used in `daos_obj_update()` calls,
which causes `RNTupleWriter::Recreate()` to not overwrite old data. This has
been fixed.
Additionally, `DAOS_COND_{D,A}KEY_FETCH` has been added to flags in
`daos_obj_fetch()` call (fail if dkey/akey does not exist).
Closes issue root-project#9032.
This commit adds the infrastructure needed to pass a data-block id as well as the slot number to data-block callbacks. At this point we still never actually _set_ the data-block id argument to something meaningful (see next commits).
This leaves out the case of RDataSources, for which data-block IDs will always be empty at the moment.
This patch adds `df.DefinePerSample`, a method that lets user define new columns that are only updated per "data-block" rather than per entry, where a "data-block" is made of several entries that have the same data-block ID (e.g. that belong to the same TTree in a TChain). The data-block ID is passed as an argument to the callback, so that quantities can be defined based on the sample being processed. Currently a jitted version is not available and RDataSources have no way to hook into the mechanism (they get one data-block per task with empty data-block ID). Support for these cases will be added by later commits. This resolves root-project#6745.
This unit test was based on the code that was used to reproduce GitHub issue root-project#9118.
Add comments clarifying what the different test categories are.
...rather than AND
Remove useless data member, we only need the value at construction time.
At the moment when browser window should be started, intermediate callback can be invoked to check that should happen. One could disable popup of the web browser to handle such call differently
Instead of popup of new window just embed created window into RBrowser
Let RBrowser to identify such window and embed them properly
When such widgets are created - automatically embed them into RBrowser
Also take care that introduced three.js methods used only when they are there
After the `RooAbsCollection::assign()` function was introduced as a better alternative to `RooAbsCollection::operator=()` in commit 4fff188, this commit now makes use of it in all the RooFit code.
One can use args.working_path = "/Home" to always start from home directory
Before only filesystem sub-dirs were handled properly, now all kind of containers will be handle similary. Important when apply filters - sub-dirs should be shown even if do not match filters
With the `-q` option, stressRooFit will not log all the errors in a given test, but will only report the final test failure when there were any errors. Tis is useful during development, allowing the developer to see which tests pass and fail at one glance without having to endlessly scroll through the ouput that gets chopped up by the detailed reports on which comparisons failed in a given test.
This is done to support the new batched evaluations mode.
rahulgrit
force-pushed
the
factor-config-func
branch
from
2c05444 to
38810fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is to simplify the role of the config in the RooLMFunc class. Currently the config is a simple struct holding the data that is need to configure the RooLMFunc in various possible ways.