Merged
Conversation
jcao-bdai
requested review from
jhavl,
myeatman-bdai and
petercorke
as code owners
myeatman-bdai
approved these changes
Nov 29, 2023
Collaborator
myeatman-bdai
left a comment
myeatman-bdai
left a comment
There was a problem hiding this comment.
Looks good to me, are we sure this is getting full coverage of all the tolerancing in the repo?
Contributor
Author
I did several passes of searching through the repo - with the second commit 619a5b3, it should be full coverage now. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
=======================================
Coverage 75.62% 75.62%
=======================================
Files 24 24
Lines 5132 5132
=======================================
Hits 3881 3881
Misses 1251 1251 ☔ View full report in Codecov by Sentry. |
jcao-bdai
force-pushed
the
SW-561/consistent-tolerance-usage-part2
branch
from
f89a091 to
619a5b3
Compare
myeatman-bdai
approved these changes
Nov 30, 2023
myeatman-bdai
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update additional cases of
tol(erance)usages in code. As an intial pass, this PR only ensures that tolerance, when provided, should be passed to sub-routine when applicable.In a follow-up, the default values and some tolerance implementation details may also be standardized.