Update more tolerance usages, add a few docstring and unit test#106
Update more tolerance usages, add a few docstring and unit test#106
Conversation
jcao-bdai
requested review from
jhavl,
myeatman-bdai and
petercorke
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 75.62% 76.49% +0.86%
==========================================
Files 24 24
Lines 5132 5134 +2
==========================================
+ Hits 3881 3927 +46
+ Misses 1251 1207 -44 ☔ View full report in Codecov by Sentry. |
jcao-bdai
force-pushed
the
SW-591/add-test-coverage
branch
from
c1612af to
6939ed8
Compare
jcao-bdai
changed the title
jcao-bdai
force-pushed
the
SW-591/add-test-coverage
branch
from
6939ed8 to
a81c21c
Compare
myeatman-bdai
left a comment
myeatman-bdai
left a comment
There was a problem hiding this comment.
Looks good to me.
| T = np.zeros((n, n), dtype="O") | ||
| else: | ||
| # numeric matrix | ||
| if not isinstance(R, np.ndarray): |
There was a problem hiding this comment.
Why was this removed? Is it redundant, or just not corrrect?
There was a problem hiding this comment.
sorry for the confusion - i squashed a commit probably when you were in the middle of reviewing. i actually restored this line to be extra cautious.
i made the initial change because there seemed to be a check, several lines above, of the same intention, so i thought this line might be redundant.
|
|
||
| if iszerovec(S, tol=tol): | ||
| raise ValueError("zero norm") | ||
| return (None, None) |
There was a problem hiding this comment.
Is this more consistent with the rest of the code?
There was a problem hiding this comment.
sorry for the confusion - i squashed a commit probably when you were in the middle of reviewing.
here i added an inline comment: # according to "note" in docstring.
| elif mode == "0:pi": | ||
| return wrap_0_pi(theta) | ||
| elif mode == "0:pi": | ||
| elif mode == "-pi/2:pi/2": |
2 participants
_epsusages (previously missed when searching withtolkeyword);angle_wrap;