Fixed code block bugs and clarified a sentence in intro.rst#120
Merged
jcao-bdai merged 1 commit intorai-opensource:masterfrom Apr 18, 2024
tjdwill:patch-1
Merged
Fixed code block bugs and clarified a sentence in intro.rst#120jcao-bdai merged 1 commit intorai-opensource:masterfrom tjdwill:patch-1
jcao-bdai merged 1 commit intorai-opensource:masterfrom
tjdwill:patch-1
Conversation
- Fixed code example bugs (~ Ln. 214 and ~Ln. 614) - ``T`` was not defined; - ``quat.qqmul`` -> ``qqmul`` - Clarified sentence at Ln. 156.
tjdwill
requested review from
jhavl,
myeatman-bdai and
petercorke
as code owners
Contributor
|
@tjdwill thank you for creating this PR, i just started the workflow to unit-test it. sorry for the late response, too! somehow i did not get any notification from this new PR, will need to fix my settings. |
1 similar comment
Contributor
|
@tjdwill thank you for creating this PR, i just started the workflow to unit-test it. sorry for the late response, too! somehow i did not get any notification from this new PR, will need to fix my settings. |
Contributor
Author
|
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twas not defined;quat.qqmul->qqmul