Dataclass for storing command IDs#48
Merged
amessing-bdai merged 2 commits intorai-opensource:mainfrom Jul 5, 2023
Merged
Conversation
2 tasks
sktometometo
suggested changes
Jul 1, 2023
Contributor
sktometometo
left a comment
sktometometo
left a comment
There was a problem hiding this comment.
https://github.com/heuristicus/spot_wrapper/blob/557b1c319915eca15265818e53d32b72b71f53de/spot_wrapper/wrapper.py#L446
This line should also be updated.
amessing-bdai
approved these changes
Jul 5, 2023
Contributor
amessing-bdai
left a comment
amessing-bdai
left a comment
There was a problem hiding this comment.
Looks good. @heuristicus Is this ready to merge?
Contributor
Author
|
Yes, this should be good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
last_*_commandattributes of the wrapper are associated with each other, but not in any proper way. This adds a dataclass to hold these attributes instead.Also adds properties to get/set the values of these attributes. This means that
AsyncIdleis no longer accessing protected members of the wrapper.This is also required for modularity purposes. The docking module sets the docking command information, and other modules may want to set other attributes.
_last_robot_command_feedbackwas unused so I removed it.