Sync with new API from judo#7
Merged
Merged
Conversation
0f4d988 to
871e4d3
Compare
There was a problem hiding this comment.
Pull request overview
Updates sumo to align with upstream judo API changes by switching to task registration objects, new dora node module paths, and new backend registry parameter names, while also bumping core dependencies and adding cleanup tooling for native extensions.
Changes:
- Migrate task registration/lookup to
TaskRegistrationobjects and pass explicit rollout/simulation backend names during registration. - Update dora node imports/configs and controller/simulation construction to use the new
*_nodemodules and*_registryparameters. - Bump
judo-raisource + MuJoCo version and add pixi clean tasks for purging stale extension artifacts.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_tasks.py | Update spot task instantiation checks to use TaskRegistration. |
| tests/test_imports.py | Update imports to new dora *_node module paths. |
| sumo/tasks/g1/g1_table_push.py | Update success() signature and use self.config for goal. |
| sumo/tasks/g1/g1_door.py | Update success() signature and use self.config for goal. |
| sumo/tasks/g1/g1_chair_push.py | Update success() signature and use self.config for goal. |
| sumo/tasks/g1/g1_box.py | Update success() signature and use self.config for goal. |
| sumo/tasks/g1/g1_base.py | Remove per-task default_backend in favor of registration-provided backends. |
| sumo/tasks/init.py | Register tasks with explicit rollout/simulation backends + Spot locomotion policy path; return TaskRegistration map. |
| sumo/run_mpc/run_mpc.py | Resolve simulation backend via task registration; update controller construction to rollout_backend_registry. |
| sumo/controller/controller.py | Update controller factory to use rollout_backend_registry and drop old rollout backend arg. |
| sumo/configs/sumo_default.yaml | Update Hydra targets to new dora node module paths. |
| sumo/app/dora/visualization_node.py | Update upstream import path to judo.app.dora.visualization_node. |
| sumo/app/dora/simulation_node.py | Update upstream import path and rename custom_backends -> backend_registry. |
| sumo/app/dora/controller_node.py | Update upstream import path to judo.app.dora.controller_node. |
| README.md | Document new pixi cleaning tasks for native extensions. |
| pyproject.toml | Point to new judo repo, bump MuJoCo constraint, add pixi clean-build/clean-all, adjust pyright settings. |
| pixi.lock | Lock updates for new judo-rai revision/version and MuJoCo 3.6.0, plus pixi options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slecleach
approved these changes
May 7, 2026
3f797f8 to
ffa561d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.